Use Bootstrap's collapse for wells. #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not perfect since the toggle button action happens instantly and the collapse has a delay but it's better than before. Any suggestions/patches welcome. |
|
/CC @Johann-S just in case you have time and any improvement ideas. |
|
Maybe that's related to : twbs/bootstrap#20870 🤔 |
Johann-S
reviewed
Jul 14, 2017
| var btnIcon = el[index].querySelector('span'); | ||
|
|
||
| el[index].addEventListener('click', function() { | ||
| document.getElementById(name).classList.toggle('hidden'); | ||
| btnIcon.classList.toggle('caret-open'); |
There was a problem hiding this comment.
Maybe you can do to change the caret only when the collapse transition ended :
setTimeout(function () {
btnIcon.classList.toggle('caret-open');
}, 350);350 is the transition duration of the Collapse plugin (https://github.com/twbs/bootstrap/blob/v3-dev/js/collapse.js#L35)
|
I haven't tried that but I will, thanks! I was trying to use transionend
but didn't spend a lot of time.
…On Jul 15, 2017 00:23, "Johann-S" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In public/assets/js/main.js
<#857 (comment)>:
> var btnIcon = el[index].querySelector('span');
el[index].addEventListener('click', function() {
- document.getElementById(name).classList.toggle('hidden');
btnIcon.classList.toggle('caret-open');
Maybe you can do :
setTimeout(function () {
btnIcon.classList.toggle('caret-open');
}, 350);
350 is the transition duration of the Collapse plugin (
https://github.com/twbs/bootstrap/blob/v3-dev/js/collapse.js#L35)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#857 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtTHgMMFh_BsCDDYLvrwTAgaRpUlWks5sN9xqgaJpZM4OYrnb>
.
|
|
👍 |
XhmikosR
force-pushed
the
xmr-bs-collapse
branch
from
a312d3a to
342d909
Compare
XhmikosR
added a commit
that referenced
this pull request
Dec 7, 2017
XhmikosR
added a commit
that referenced
this pull request
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.